Solari: Light leak reduction and stochastic WC update#22348
Merged
alice-i-cecile merged 9 commits intobevyengine:mainfrom Jan 13, 2026
Merged
Solari: Light leak reduction and stochastic WC update#22348alice-i-cecile merged 9 commits intobevyengine:mainfrom
alice-i-cecile merged 9 commits intobevyengine:mainfrom
Conversation
SparkyPotato
suggested changes
Jan 2, 2026
atlv24
reviewed
Jan 13, 2026
| const WORLD_CACHE_POSITION_BASE_CELL_SIZE: f32 = 0.15; | ||
| /// How fast the world cache transitions between LODs as a function of distance to the camera | ||
| const WORLD_CACHE_POSITION_LOD_SCALE: f32 = 8.0; | ||
| const WORLD_CACHE_POSITION_LOD_SCALE: f32 = 15.0; |
Contributor
There was a problem hiding this comment.
how hard will it be to make all these constants uniforms tweakable from Resource someday?
Contributor
Author
There was a problem hiding this comment.
Easy, just not a priority atm. It's on the tracking issue.
atlv24
approved these changes
Jan 13, 2026
ChristopherBiscardi
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Objective
Solution
To prevent light leaks:
Since this then greatly increases the number of cache cells in the scene, I changed the following to prevent too much of a decrease in performance (this PR is still a hit to performance though):
Also some misc changes:
Ideally the skipped cells wouldn't be totally random, and we'd have coarser-LOD cells update less frequently, but that would get very complicated as we'd have to track the total amount of cells per LOD in order to average out to
WORLD_CACHE_TARGET_CELL_UPDATES.